Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary FreeForAll info, add map hint to Danger Zone, indent mod #2318

Merged
merged 1 commit into from Apr 28, 2019
Merged

Unnecessary FreeForAll info, add map hint to Danger Zone, indent mod #2318

merged 1 commit into from Apr 28, 2019

Conversation

borzaka
Copy link
Contributor

@borzaka borzaka commented Apr 28, 2019 •
edited

Description

  • no need for FreeForAll text for Danger Zone
  • add map hint to Danger Zone (only map that can be used with this gamemode at the moment)
  • and some indentation fix

Type of change

  • Bug fix (change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, etc).
  • This change requires a documentation update.

Checklist

  • This code follows the style guidelines of this project.
  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • I have provided Co-author details below.
  • I have performed a self-review of my own code.
  • I have squashed commits.
  • I have commented my code, particularly in hard to understand areas.
  • I have made corresponding changes to the documentation if required.

Provide Github Email

Co-authored-by: Borzák Attila <1230402+borzaka@users.noreply.github.com>
  • I do not wish to provide an email. I am aware this will hide me as the author of this commit.

@dgibbs64 dgibbs64 merged commit b8f1c67 into GameServerManagers:develop Apr 28, 2019
@dgibbs64 dgibbs64 added this to the new release milestone Apr 28, 2019
@dgibbs64
Copy link
Member

@allcontributors[bot] add @borzaka for code and bug contributions

@allcontributors allcontributors bot mentioned this pull request Apr 28, 2019
Merged
@allcontributors
Copy link
Contributor

@dgibbs64

I've put up a pull request to add @borzaka! 🎉

@borzaka
Copy link
Contributor Author

borzaka commented Apr 29, 2019

Thx :)

@borzaka borzaka deleted the patch-1 branch April 29, 2019 09:15
@conventional-release-bot conventional-release-bot bot mentioned this pull request May 3, 2019
Merged
@lock
Copy link

lock bot commented May 5, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
game: Counter-Strike: Global Offensive type: refactor
Projects
None yet
Milestone
v15.5.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@borzaka @dgibbs64